uploadwithreplaydata should fallback to uploadscore if there is no data

src/Etterna/Singletons/DownloadManager.cpp

@@ -1081,16 +1081,22 @@ DownloadManager::UploadScoreWithReplayData(HighScore* hs)
 	HTTPRequests.push_back(req);
 	return;
 }
-void // not tested exhaustively -mina
+
+// for older scores or newer scores that failed to upload using the above
+// function we should probably do some refactoring of this
+void
 DownloadManager::UploadScoreWithReplayDataFromDisk(const string& sk,
 												   function<void()> callback)
 {
 	if (!LoggedIn())
 		return;
 
 	auto* hs = SCOREMAN->GetScoresByKey().at(sk);
+	// this should never be true unless we are using the manual forceupload
+	// functions, in which case we will defer to the scoreuploader that
+	// does not use replaydata
 	if (!hs->HasReplayData())
-		return;
+		UploadScore(hs);
 
 	CURL* curlHandle = initCURLHandle(true);
 	string url = serverURL.Get() + "/score";