Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS Catalina Crashing #686

Merged
merged 6 commits into from
May 9, 2020

Conversation

jameskr97
Copy link
Member

macOS Catalina had a change in their OpenGL API. Specifically one which crashes game if mac related UI updates are done off of the main thread. The issue is fixed by running the line which crashes the application in an asynchronous block to be sent to the main thread for execution.

macOS Catalina had a change in their OpenGL API. Specifically one which prevents the game from running if mac related UI updates are done off of the main thread. The issue is fixed by running the line which crashes the application in an asynchronous block to be sent to the main thread for execution.
@poco0317
Copy link
Member

I don't see anything particularly wrong with it, and it seems like the function used is supported on 10.6+

If it runs for you it's probably good. We might want to get someone on something older than Catalina to test, but that would probably be a hassle.

@jameskr97
Copy link
Member Author

I don't see anything particularly wrong with it, and it seems like the function used is supported on 10.6+

If it runs for you it's probably good. We might want to get someone on something older than Catalina to test, but that would probably be a hassle.

The dispatch_async and dispatch_get_main_queue() functions are a part of Apple's Dispatch framework, previously known as Grand Central Dispatch. It's been supported since 2009 in one form or another. But definitely if other's running Catalina could also test, that would be very appreciated.

@lmiller1990
Copy link

I am struggling to even build for Catalina. I made an issue about it - #718. How did you get it to run on Catalina?

@jameskr97
Copy link
Member Author

jameskr97 commented Mar 22, 2020

I am struggling to even build for Catalina. I made an issue about it - #718. How did you get it to run on Catalina?

I was building with xcode. The issue you are experiencing in #718 is a problem that, I believe, happens when linking with ninja specifically. I made a comment there asking for your build output if you get a chance to respond to that.

Commenting out this input prevents a crash when selecting "Game Start" at the main menu followed by creating a profile.
@nico-abram
Copy link
Member

@jameskr97 Do you think we should merge this before the next release since it makes the game crash on latest macos? This has not been tested on older versions yet, right?

Aside, could you explain the change to KeyCodeToChar? Did you try using different keyboard layouts/languages in case something broke?

jameskr97 and others added 3 commits April 21, 2020 22:40
After testing if this function would affect key pressing, it was found that it didn't. The keyboard input is unchanged. Obsolete function removed.
@nico-abram nico-abram merged commit 86dd697 into etternagame:develop May 9, 2020
@jameskr97 jameskr97 deleted the feature/macos-catalina branch May 24, 2020 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants