Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and add : fix ConfirmFragment and add ConfirmFragmentTest #19

Merged
merged 8 commits into from
Aug 26, 2021

Conversation

kmsaidev
Copy link
Collaborator

fix ConfirmFragment and add ConfirmFragmentTest

  • fix string in ConfirmFragment
  • add ConfirmFragmentTest
  • Create a testButtonClick method on the ConfirmFragmentTest

Copy link
Collaborator

@judemin judemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@kmsaidev kmsaidev requested review from judemin, eunzinn and kuro11pow2 and removed request for kuro11pow2 and eunzinn August 23, 2021 15:34
Copy link
Member

@kuro11pow2 kuro11pow2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit test for the fragment looks difficult to me! Could you explain the overall code flow?

@kmsaidev
Copy link
Collaborator Author

The unit test for the fragment looks difficult to me! Could you explain the overall code flow?

I haven't finished writing it yet, so I don't have a full flow, but it's just a code to test the confirm button using espresso.

Copy link
Member

@kuro11pow2 kuro11pow2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Collaborator

@eunzinn eunzinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gooood~~!

@eunzinn eunzinn merged commit aef835b into euphony-io:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants