-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YAML batch_1 update #100
YAML batch_1 update #100
Conversation
Hi @santilland, I have added here a possible proprietary license. I added the license file as a "more information" link. |
hi @FedericoRondoni, interesting idea, but i think we will have to handle this differently.
|
Hello @FedericoRondoni , I have been thinking about it and adding an additional field for this seems a bit unnecessary and complicates understanding for someone providing the information, so i would propose following, the license can be either a string, with an identifier that matches one of the spdx license identifiers or it can be a list of license objects. So in examples the options would be:
or
|
…d1 config file accordingly
I updated the license parsing approach to mirror the proposed changes and updated also the yaml config, from my side this would be ok to be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed approach looks good to me, implementation done, ok to be merged
Hi @santilland that's perfect. |
However, before merging, I will probably add more YAML files to this branch, so I think we need to run a check again. |
Ok, let me know when it is ok to merge. As an alternative we can merge this one and you can open a new branch that already has the implemented feature. |
OK, I agree. Let me just add the CDS2 yaml so we have all of them, and then we can merge. |
Ok, I think we can merge. Should I do that? |
I merged and I will integrate these changes in to the other branch |
CDS1_temperature CDS2_relative_humidity