-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update yaml files #84
Conversation
Test to understand if the nested DataSource element can be used for the YAML files + integration of the new References element inside the YAML
Hi @santilland @lubojr |
Hello @FedericoRondoni , we changed the automatic generation and deployment of the catalog for branches, it now possible to specify which collections one wants to test, instead of always generating all collections. |
Hi @santilland and thanks for your reply. How can I do that? |
You can write the list of collection identifiers (separated by spaces) you want to test in the body of the pull request. So by editing the first "comment" of the pull request. After you push a commit it should then only generate the collections provided in that list. |
Like this? |
No problem, it is not common use what we are doing here, so questions are very much welcome, we will need to better describe and document the process we are still evaluating. C1_ports_shipping_aq CDS3_wind_10m_u |
Ah ok! Clear |
Looks good, this should apply for your next commit then |
@FedericoRondoni please make sure that the license field uses a spdx license identifier as defined here: |
Hi Daniel, I checked already, but I couldn't find any relevant license. I will check again. |
If i understand the STAC definition, the value can also be various or proprietary. We could set the license to proprietary and then add the license definition as asset if it exists online somewhere or we save it in the assets repository |
* fix: invalids yaml indentation; made type optional for service sh endpoint * chore: fixing DataSource structure, reapplying yaml formatting * feat: implemented loading of DataSource options * chore: removed no longer needed code
Hi @santilland, I also added the license field to two yaml files here, but maybe there is something that you need to implement in this branch as well? |
Yes, we will need to merge the updates from the other branch to this one, i can do it once we merge the other branch |
Ok perfect! |
All right, changes integrated, automatic build is passing now again |
Hi guys @santilland @lubojr once the merging of the assets branch YAML-alignment is done, we can ask Anca to review these YAMLs and descriptions. |
@aapopescu this pull request is the first batch ready to be merged, you can see the preview of the catalog with following url: |
collections/C3_ports_people_aq.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is the Subtitle used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we group all three indicators into a single one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are current not displaying it in the dashboard, i thought while doing data sanitation it might be an interesting attribute to have if we ever decide to include it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cannot find this indicator on the test URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems it is not added in the pull request description for it to be generated, will recheck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, you are right. Now it should be ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename to "Vessel Density - all types of ships"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we group all EMODNET indicators into a single one?
@FedericoRondoni @aapopescu the new stac structure was introduced and merged into this branch, we also merged the test branch of the client, so you can explore the client with the current data here: |
@FedericoRondoni Please whenever there are renamings of the name of YAML files, these changes need to be reflected in the corresponding catalog YAML, otherwise the build fails. I will take care of fixing this in the already merged PRs batch_3, batch_4 and batch_5 but could you please address the issues in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adapt RACE.yaml to file renamings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah nevermind, it is already done in this PR, sorry. It was just the issue in batch_3, batch_4, and batch_5
CAQ_ports_air_quality E13o_vessel_density_all E13p_vessel_density_cargo E13q_vessel_density_tanker E13r_vessel_density_others C3S_meteorological_variables