Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Ships-detection indicator on-the-fly integration #2349

Merged
merged 14 commits into from
Apr 8, 2024

Conversation

viktoraronfarkas
Copy link
Contributor

@viktoraronfarkas viktoraronfarkas commented Oct 24, 2023

Will integrate #2330

@viktoraronfarkas viktoraronfarkas self-assigned this Oct 24, 2023
@lubojr lubojr changed the title Add datepicker Integrates Ships-detection indicator on-the-fly integration Oct 24, 2023
@lubojr lubojr changed the title Integrates Ships-detection indicator on-the-fly integration Integrate Ships-detection indicator on-the-fly integration Oct 24, 2023
@lubojr lubojr added data integration enhancement New feature or request labels Oct 24, 2023
@lubojr lubojr marked this pull request as ready for review March 27, 2024 14:39
@lubojr
Copy link
Member

lubojr commented Mar 27, 2024

@aapopescu The ship detection algorithm has been integrated at testing branch https://eodash-testing.eox.at/add-datepicker/?poi=World-E13c_ship_detection

There is a max drawn area limit implemented (15x15km) for this indicator because there is a size limit of how large image can we request at once from SH.

test-2024-03-27_16.10.15.mp4
  • We would still need a markdown description (I did not find if we have already received it).
  • TODO: FIX The map loading indicator is not connected to this feature layer, so it is not clear to potential user directly that the server is still processing the detections - because all tiles have loaded already and loading indicator is gone
  • for this case (ONLY) initiate fetch only by button
  • prepare STAC catalog YAML -> prepare E13c_ship_detections based on E200 as base eodash-catalog#119

@lubojr lubojr requested review from aapopescu and removed request for lubojr April 2, 2024 07:20
lubojr added 2 commits April 5, 2024 16:32
added a new fetch button again with a loading spinner
@lubojr
Copy link
Member

lubojr commented Apr 8, 2024

Merging without the markdown to staging to avoid merge conflicts later downstream. Markdown can be added later.

@lubojr lubojr merged commit 9e06c04 into staging Apr 8, 2024
5 checks passed
@lubojr lubojr deleted the add-datepicker branch April 11, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data integration enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants