Exhibition widget and a more sane repr for closed UniverseWidget #200
Conversation
There was a problem hiding this comment.
Added a few comments/questions. The exhibition_widget is a very nice addition (both for advertising and for ad-hoc testing). I'm thinking there are two pieces to automate those tests: first need to use selenium or something to automate browser actions and second need to include some kind of successful message when all promises are fulfilled (and rejection messages when not fulfilled). Is that about right or not quite?
|
I like the idea of sending a message back to the kernel on promise fulfillment. And yes presumably we can set up a selenium test to run in CI. I will see what it will take to get some of that going as part of this PR. |
…into issue-192
There was a problem hiding this comment.
Thank you for implementing automatic testing. Thank you for the massive updates to the integration with three.js. I'm a big fan of the use of TS as well. The changes are well thought out and now that we have some testing (plus the exhibition widget) it's pretty easy to make sure future changes don't break things.
…into issue-192
tjduigna
added
the
Visualizations
|
Closing as stale - will reopen as appropriate. |
Hey I saw you assign #192 to me, thanks for reminding me about this.
There are 3 open issues with this MR:The new widget has a kludge for sizing the renderer.The method still uses offsetHeight rather than canvas height but the growing/shrinking widget is actually related to the element offsetHeight instability during kernel reset. Instead, it makes an explicit check whether the widget is connected to the kernel before attempting to resize.The selenium script throws a timeout exception in the travis build.Not so much a workaround, more of a punt. The test script will handle this exception. It is still a useful development test script and brings us much closer to CI testing for widgets.The CI pipeline does not work for both linux and macos right now.Parametrizing both chrome and firefox driver installation on both mac and linux is complete. This at least makes it easier to resolve 2 in the future.