chore: Use rustls, remove dependency on OpenSSL #229
Conversation
|
this is a very delicate issue. I understand that there are valid reasons to use rustls over openssl because of some advantages; the biggest point it's that is simpler to integrate in a rust project and another could be that it's a modern, safer tls implementation compared to openssl; or one could argue that openssl had many cves in the recent years. while this are truly good points openssl is by far the most used and battle tested cryptographic library and fundamental component of every system. For a native installation a dependency on shared openssl system library is probably better, but I could be wrong. what I think instead is that we could support both and let the user or the packager choose |
|
@banditopazzo Sure, I'm fine with giving a choice. But I would be still inclined to use rustls for official container images, so we don't have to install libssl-dev. |
vadorovsky
force-pushed
the
rustls
branch
15 times, most recently
from
10515e9 to
1b09c30
Compare
ring 0.17 supports RISC-V, so building Pulsar with rustls instead of OpenSSL is possible. Choice of the TLS library is exposed by the following features in the `smtp-notifier` crate: * `native-tls` - uses the native TLS library in the system, usually OpenSSL. Enabled by default. * `boring-tls` - uses BoringSSL. Disabled by default. * `rustls-tls` - uses rustls. Disabled by default. When building Pulsar with Cargo, the native TLS is going to be used. However, for binary builds for Github releases, rustls is being used, since it's always statically built and doesn't require any runtime dependencies from the users.
|
Superseeded by #278, this PR has too much mess |
ring 0.17 supports RISC-V, so building Pulsar with rustls instead of OpenSSL is possible.
Choice of the TLS library is exposed by the following features in the
smtp-notifiercrate:native-tls- uses the native TLS library in the system, usually OpenSSL. Enabled by default.boring-tls- uses BoringSSL. Disabled by default.rustls-tls- uses rustls. Disabled by default.When building Pulsar with Cargo, the native TLS is going to be used.
However, for binary builds for Github releases, rustls is being used, since it's always statically built and doesn't require any runtime dependencies from the users.