Update Dedoc Verison and Spatie Query Builder Version. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for contribution. |
…re going to exception handle with default value for user who are using Latest stable version of: "dedoc/scramble": "^0.11.0", "spatie/laravel-query-builder": "^6.0" Update sorts extension with available sort parameter.
layerok
reviewed
Aug 16, 2024
src/AllowedFilterModesExtension.php
Outdated
| @@ -30,7 +30,7 @@ public function handle(Operation $operation, RouteInfo $routeInfo) | |||
|
|
|||
| $values = $helper->inferValues($methodCall, $routeInfo); | |||
|
|
|||
| $parameter = new Parameter(config(AllowedFilter::FilterModesQueryParamConfigKey), 'query'); | |||
| $parameter = new Parameter(config(AllowedFilter::FilterModesQueryParamConfigKey)??"filter_mode", 'query'); | |||
There was a problem hiding this comment.
you can just exclude AllowedFilterModesExtension from scramble extensions (config/scramble.php).
That way you won't get any exceptions for reading non-existent config key. There is no need to add this change. Please, remove it
There was a problem hiding this comment.
Yep. I was missing that. Will update on that. Thank you.
|
here is command to run tests ./vendor/bin/pest |
Even though Test will be failed, as it does not match with existing expected value and structure. Also current sort doesn't show which key are available as sort option. So include those information on description, with-out affection other flows of sort. Also work well with Dedoc Scramble Documentation testing. Revert back to original author for Allowed FilterModes Extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issues with sort-names.
Update dependency version.