Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configure automatic-translation navigation and pages for administration site - EXO-66546 - Meeds-io/MIPs#88 #43

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

IlhemEssaadi
Copy link
Contributor

No description provided.

@exo-swf exo-swf force-pushed the feature/experience branch from 6e8fd92 to 2683179 Compare October 11, 2023 22:34
@IlhemEssaadi IlhemEssaadi changed the title Add translation node to the navigation of Platform settings - EXO-66546 - Meeds-io/MIPs#88 feat: Configure automatic-translation navigation and pages for administration site - EXO-66546 - Meeds-io/MIPs#88 Oct 12, 2023
@IlhemEssaadi IlhemEssaadi requested a review from azayati October 12, 2023 14:10
@hakermi hakermi force-pushed the feature/experience branch from a18268e to 927868e Compare October 12, 2023 14:24
@@ -35,5 +35,37 @@
</object-param>
</init-params>
</component-plugin>
<component-plugin>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format code

<access-permissions>*:/platform/administrators</access-permissions>
<edit-permission>manager:/platform/administrators</edit-permission>
<show-max-window>false</show-max-window>
<container id="singlePageApplicationContainer" template="system:/groovy/portal/webui/container/UIContainer.gtmpl">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cssClass missing

<container
id="topAnalyticsPage"
template="system:/groovy/portal/webui/container/UIContainer.gtmpl"
cssClass="singlePageApplication border-box-sizing">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cssClass="singlePageApplication border-box-sizing">
cssClass="singlePageApplication">

</value>
</collection>
</field>
<field name="ownerType">
<string>group</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<string>group</string>
<string>group</string>

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@azayati azayati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azayati azayati merged commit faae69d into feature/experience Oct 12, 2023
@azayati azayati deleted the task/66546 branch October 12, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants