feat: Add java-deepl library to project packaging - EXO-66770 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkrout
approved these changes
Oct 12, 2023
hakermi
force-pushed
the
feature/experience
branch
from
a18268e to
927868e
Compare
Prior to this change, the java-deepl is not included in project packaging as it's needed. This PR, adds the library to the project packaging
|
Kudos, SonarCloud Quality Gate passed!
|
exo-swf
pushed a commit
that referenced
this pull request
Oct 20, 2023
exo-swf
pushed a commit
that referenced
this pull request
Oct 22, 2023
hakermi
added a commit
that referenced
this pull request
Oct 23, 2023
Add DeepL trasnlate connector feat: Add java-deepl library to project packaging - EXO-66770 (#45) Prior to this change, the java-deepl is not included in project packaging as it's needed. This PR, adds the library to the project packaging fix: issue in google translator connector whith text contains single quote char - EXO-66886 (#52) Prior to this change, when attempting to translate a text with a simple quote char with google translator, the connector fails due to existing quote char in the text due to the use of signle quotes in the request param. This prevents this situation by using escaped double quotes in the qurey param.
hakermi
added a commit
that referenced
this pull request
Oct 23, 2023
Add DeepL trasnlate connector feat: Add java-deepl library to project packaging - EXO-66770 (#45) Prior to this change, the java-deepl is not included in project packaging as it's needed. This PR, adds the library to the project packaging fix: issue in google translator connector whith text contains single quote char - EXO-66886 (#52) Prior to this change, when attempting to translate a text with a simple quote char with google translator, the connector fails due to existing quote char in the text due to the use of signle quotes in the request param. This prevents this situation by using escaped double quotes in the qurey param.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the java-deepl is not included in project packaging as it's needed. This PR, adds the library to the project packaging