Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: html spaces entities are removed after translation in news and notes content - EXO-65429 #49

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

hakermi
Copy link
Member

@hakermi hakermi commented Oct 17, 2023

Prior to this change, after requesting a translation of html content all   html symbols are removed which causing a formatting issue when it comes to an empty tag with only space like a new line in ckeditor with paragraph enter mode.
This PR adds a workaround to avoid such issue in translators with this behavior as DeepL

…otes content - EXO-65429

Prior to this change, after requesting a translation of html content all   html symbols are removed which causing a formatting issue when it comes to an empty tag with only space
like a new line in ckeditor with paragraph enter mode.
This PR adds a workaround to avoid such issue in translators with this behavior as DeepL
@hakermi hakermi requested a review from mkrout October 17, 2023 19:00
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@exo-swf exo-swf added the partialCIBuild Perform Partial CI Build label Oct 17, 2023
@hakermi hakermi merged commit 6fb56dc into feature/experience Oct 17, 2023
3 checks passed
@hakermi hakermi deleted the TASKK-65429 branch October 17, 2023 19:15
exo-swf pushed a commit that referenced this pull request Oct 20, 2023
…otes content - EXO-65429 (#49)

Prior to this change, after requesting a translation of html content all   html symbols are removed which causing a formatting issue when it comes to an empty tag with only space
like a new line in ckeditor with paragraph enter mode.
This PR adds a workaround to avoid such issue in translators with this behavior as DeepL
exo-swf pushed a commit that referenced this pull request Oct 22, 2023
…otes content - EXO-65429 (#49)

Prior to this change, after requesting a translation of html content all   html symbols are removed which causing a formatting issue when it comes to an empty tag with only space
like a new line in ckeditor with paragraph enter mode.
This PR adds a workaround to avoid such issue in translators with this behavior as DeepL
hakermi added a commit that referenced this pull request Oct 23, 2023
…otes content - EXO-65429 (#49)

Prior to this change, after requesting a translation of html content all   html symbols are removed which causing a formatting issue when it comes to an empty tag with only space
like a new line in ckeditor with paragraph enter mode.
This PR adds a workaround to avoid such issue in translators with this behavior as DeepL

fix: unhandeld check in auto translate extensions in notes and news in case of null contents - EXO-65764 (#50)

prior to this change, when trying to translate a news with empty summary or a note with empty content, an exceptio is raised.
This PR adds missing checks of those empty attributes to avoid such issue
hakermi added a commit that referenced this pull request Oct 23, 2023
…otes content - EXO-65429 (#49)

Prior to this change, after requesting a translation of html content all   html symbols are removed which causing a formatting issue when it comes to an empty tag with only space
like a new line in ckeditor with paragraph enter mode.
This PR adds a workaround to avoid such issue in translators with this behavior as DeepL

fix: unhandeld check in auto translate extensions in notes and news in case of null contents - EXO-65764 (#50)

prior to this change, when trying to translate a news with empty summary or a note with empty content, an exceptio is raised.
This PR adds missing checks of those empty attributes to avoid such issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
partialCIBuild Perform Partial CI Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants