fix: unhandeld check in auto translate extensions in notes and news in case of null contents - EXO-65764 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n case of null contents - EXO-65764 prior to this change, when trying to translate a news with empty summary or a note with empty content, an exceptio is raised. This PR adds missing checks of those empty attributes to avoid such issue
|
Kudos, SonarCloud Quality Gate passed!
|
mkrout
approved these changes
Oct 18, 2023
hakermi
added a commit
that referenced
this pull request
Oct 23, 2023
…otes content - EXO-65429 (#49) Prior to this change, after requesting a translation of html content all html symbols are removed which causing a formatting issue when it comes to an empty tag with only space like a new line in ckeditor with paragraph enter mode. This PR adds a workaround to avoid such issue in translators with this behavior as DeepL fix: unhandeld check in auto translate extensions in notes and news in case of null contents - EXO-65764 (#50) prior to this change, when trying to translate a news with empty summary or a note with empty content, an exceptio is raised. This PR adds missing checks of those empty attributes to avoid such issue
hakermi
added a commit
that referenced
this pull request
Oct 23, 2023
…otes content - EXO-65429 (#49) Prior to this change, after requesting a translation of html content all html symbols are removed which causing a formatting issue when it comes to an empty tag with only space like a new line in ckeditor with paragraph enter mode. This PR adds a workaround to avoid such issue in translators with this behavior as DeepL fix: unhandeld check in auto translate extensions in notes and news in case of null contents - EXO-65764 (#50) prior to this change, when trying to translate a news with empty summary or a note with empty content, an exceptio is raised. This PR adds missing checks of those empty attributes to avoid such issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prior to this change, when trying to translate a news with empty summary or a note with empty content, an exception is raised. This PR adds missing checks of those empty attributes to avoid such issue