Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

62 refine querycontext 2v #70

Merged
merged 22 commits into from
Feb 6, 2025
Merged

62 refine querycontext 2v #70

merged 22 commits into from
Feb 6, 2025

Conversation

alfy91
Copy link
Collaborator

@alfy91 alfy91 commented Feb 4, 2025

resolve #62

@alfy91 alfy91 requested a review from rolyp February 4, 2025 15:50
alfy91 added 16 commits February 5, 2025 10:55
@alfy91
[update] adding expression to test cases
c0be41b
@alfy91
[update] manage the paragraph object in the query context
d21cd3a
@alfy91
[update] manage the paragraph object in the query context
723cc45
@alfy91
[update] moved file from input folder to project home
ee5ea6f
@alfy91
[update] rename script build-executor
0fba002
@alfy91
[update] removed script to install fluid tool
51c0192
@alfy91
[update] remove logic and parameters from the script
5957a04
@alfy91
[update] ops. removed debug sentence
fbb59f9
@alfy91
[update] one instance of authoring assistant for multiple querycontex…
e490fe3 
…t objects
@alfy91
[update] added test file path to improve log messages
3c98288
@alfy91
[update] fix on learning case and test case
9703a14
@alfy91
[update] change getSplitParagraph and added methods in settings
e9f48dd
@alfy91
[update] removed parameters from yarn commands
9eeb7bd
@alfy91
[update] align workflow with build command
dfe2539
@alfy91
[update] fix permission
57f01e5
@alfy91
[update] clone prompt to separate session and limit execution to 1 se…
177b57e 
…ntence
rolyp
rolyp approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@rolyp rolyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alfonso, this is much better and hopefully has been a useful exercise in terms of making the design more explicit in the code.

addExpressionToParagraph and getSplitParagraph I think may still need some work but we can discuss that separately.

authoringAssistant/src/main/java/explorableviz/transparenttext/QueryContext.java Show resolved Hide resolved
authoringAssistant/src/main/java/explorableviz/transparenttext/QueryContext.java Outdated Show resolved Hide resolved
authoringAssistant/src/main/java/explorableviz/transparenttext/AuthoringAssistant.java Outdated Show resolved Hide resolved
@rolyp rolyp merged commit 354aa22 into main Feb 6, 2025
7 checks passed
@rolyp rolyp deleted the 62-refine-querycontext-2v branch February 6, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolyp rolyp rolyp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Fluid
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refine QueryContext.text into paragraph
2 participants
@alfy91 @rolyp