Add dynamic children prop support (react-native-read-more-text) #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dynamic children prop support so if children was changed it's being taken into account while setting component state leading to proper "Show more", "Show less" buttons behaviour
vtsybulin
changed the title
|
@brentvatne Hi. Any chance this could be reviewed? Thanks. |
|
Make sure you check it, I have this error sometimes:
|
|
i think the best path forward is for someone to make a new version of this library, and i can mark it as archived since we no longer maintain it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dynamic children prop support so if children are changed it's being taken into account while setting component state leading to proper "Show more", "Show less" buttons behavior.
The problem: if the children prop is a dynamic one, the component doesn't behave as expected (meaning "Show more" button visibility is being decided only on the mount stage).
Current behavior:
Desired behavior:
