Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply WolfSSL Poly1305 Aarch64 PR fix #186

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

kp-thomas-yau
Copy link
Contributor

@kp-thomas-yau kp-thomas-yau commented Dec 11, 2024

Description

Apply the wolfSSL/wolfssl#8275 PR fix. The original revert patch was here to fix mismatched tag when we are using ChaCha20 in TCP connection. See #183

Motivation and Context

Use official fix from WolfSSL instead of reverting it

How Has This Been Tested?

Passed coverage test for our clients

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All active GitHub checks are passing
  • The correct base branch is being used, if not main

Apply the wolfSSL/wolfssl#8275 PR fix. The original revert patch was here to fix mismatched tag when we are using ChaCha20 in TCP connection. See #183
@kp-thomas-yau kp-thomas-yau marked this pull request as ready for review December 11, 2024 10:18
@kp-thomas-yau kp-thomas-yau requested a review from a team as a code owner December 11, 2024 10:18
@kp-thomas-yau kp-thomas-yau merged commit 3aff9f6 into main Dec 12, 2024
20 checks passed
@xv-raihaan-m xv-raihaan-m deleted the apply-wolfssl-poly1305-pr branch December 30, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants