Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize multibuy database queries #469

Open
wants to merge 10 commits into
base: next
Choose a base branch
from
Open

Optimize multibuy database queries #469

wants to merge 10 commits into from

Conversation

patrickreiffenstein
Copy link
Contributor

@patrickreiffenstein patrickreiffenstein commented Jun 12, 2024 •
edited by krestenlaust
Loading

Fixes #357.

@krestenlaust krestenlaust changed the title Duplicate query removal when buying Optimize multibuy database queries Jun 13, 2024
krestenlaust
krestenlaust reviewed Jun 13, 2024
View reviewed changes
Copy link
Member

@krestenlaust krestenlaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to run it locally to check things over, and verify that we have tests in place

stregsystem/models.py Outdated Show resolved Hide resolved
stregsystem/models.py Outdated Show resolved Hide resolved
@krestenlaust krestenlaust self-requested a review June 13, 2024 07:51
@krestenlaust
Copy link
Member

krestenlaust commented Aug 5, 2024 •
edited
Loading

I'll try to review this before summer ends. Probably after the current update has been finished

@JakobTopholt
Copy link
Contributor

@Mast3rwaf1z Vil du ikke være en king og review den her så Kresten kan få lidt fritid?

@krestenlaust
Copy link
Member

♥️ jeg vil dog stadig gerne merge den

@Mast3rwaf1z
Copy link
Member

@Mast3rwaf1z Vil du ikke være en king og review den her så Kresten kan få lidt fritid?

Tager lige et kig senere, var lige til forelæsning

Mast3rwaf1z
Mast3rwaf1z requested changes Sep 9, 2024
View reviewed changes
Copy link
Member

@Mast3rwaf1z Mast3rwaf1z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things, i think improves readability of the code, and removed some redundant constructor calls?

also i believe by using _ in a for loop prevents memory being allocated to the variable. really insignificant but hey, its good to have imo

stregsystem/models.py Outdated Show resolved Hide resolved
stregsystem/views.py Outdated Show resolved Hide resolved
stregsystem/views.py Outdated Show resolved Hide resolved
stregsystem/views.py Outdated Show resolved Hide resolved
@krestenlaust krestenlaust marked this pull request as draft September 24, 2024 21:50
@krestenlaust krestenlaust removed their request for review September 24, 2024 21:50
@patrickreiffenstein @krestenlaust @Mast3rwaf1z
Apply suggestions from code review
5f8ae12 
Added the suggestions from Kresten and Thomas, which seems to be some good changes

Co-authored-by: Kresten Laust <[email protected]>
Co-authored-by: Thomas Jensen <[email protected]>
@patrickreiffenstein patrickreiffenstein marked this pull request as ready for review January 11, 2025 20:17
Mast3rwaf1z
Mast3rwaf1z approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@Mast3rwaf1z Mast3rwaf1z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, minor annoying naming issue

stregsystem/views.py Outdated Show resolved Hide resolved
Mast3rwaf1z
Mast3rwaf1z reviewed Jan 13, 2025
View reviewed changes
stregsystem/views.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mast3rwaf1z Mast3rwaf1z Mast3rwaf1z approved these changes

@krestenlaust krestenlaust Awaiting requested review from krestenlaust

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Start of Fall Semester 2024
Development

Successfully merging this pull request may close these issues.

Poor performance on high amount of products bought (even with multibuy)
4 participants
@patrickreiffenstein @krestenlaust @JakobTopholt @Mast3rwaf1z