Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Signup to Rest API #543

Open
wants to merge 20 commits into
base: next
Choose a base branch
from
Open

Add Signup to Rest API #543

wants to merge 20 commits into from

Conversation

krestenlaust
Copy link
Member

@krestenlaust krestenlaust commented Dec 26, 2024

Increments API version from 1.1 to 1.1.1

Resolves #542
Prerequisite: #550

Documentation:

  • Add [POST] /api/signup for posting signups
  • Add [GET] /api/signup/status for querying status regarding a signup

Implementation:

  • [POST] /api/signup
  • [GET] /api/signup/status

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.80%. Comparing base (a02bfdb) to head (b7df05b).
Report is 4 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #543   +/-   ##
=======================================
  Coverage   80.80%   80.80%           
=======================================
  Files          40       40           
  Lines        3809     3809           
  Branches      481      481           
=======================================
  Hits         3078     3078           
  Misses        675      675           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

It was in the middle of some private methods not related to it
@krestenlaust
Copy link
Member Author

I made the mistake to make signups lookup-able by ID, let's avoid this, and only lookup signup status by username

@krestenlaust krestenlaust marked this pull request as ready for review January 13, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to Post signup with rest API
1 participant