Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#64] Argument Resolver 리팩토링/Jacoco Report 설정 #67

Closed
wants to merge 8 commits into from

Conversation

hoa0217
Copy link
Collaborator

@hoa0217 hoa0217 commented Mar 27, 2024

개요

LoginMemberArgumentResolver 리팩토링 및 Jacoco Report를 PR에 가시적으로 보여줄 수 있게 CI를 변경하였습니다.

작업사항

  • LoginMemberArgumentResolver Session을 주입받는 대신 파라미터로 제공되는 webRequest를 이용하여 세션에 접근하도록 수정
  • Jacoco Report to PR 설정

참고: https://github.com/Madrapps/jacoco-report?tab=readme-ov-file

변경로직

  • 어플리케이션 로직변경 없음.

hoa0217 added 3 commits March 28, 2024 00:42
- request 파라미터에서 Session을 직접 가져오는 방법으로 변경

Related: #64
- PR 생성 시 빌드된 레포트를 PR에 가시적으로 보여줌.

Related: #64
- 블로그 글 추가

Related: #64
@hoa0217 hoa0217 self-assigned this Mar 27, 2024
Copy link

⭐️Code Coverage

Overall Project 74.19% -0.18%
Files changed 0%

File Coverage
LoginMemberArgumentResolver.java 13.64% -45.45%

hoa0217 added 2 commits March 28, 2024 12:20
Jacoco Report to PR 시 Instruction 기준으로 체크되므로 변경

Related: #64
- 비지니스로직이 아닌 클래스 테스트커버리지 체크에서 제외한다.

Related: #64
@hoa0217 hoa0217 closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant