CMake: Add a check for VTK_READER/VTK_IMPORTER in plugin CMake logic (#…

…1661)

Co-authored-by: Michael MIGLIORE <[email protected]>

cmake/f3dPlugin.cmake

@@ -129,6 +129,10 @@ macro(f3d_plugin_declare_reader)
     set(F3D_READER_HAS_GEOMETRY_READER 0)
   endif()
 
+  if (NOT F3D_READER_HAS_SCENE_READER AND NOT F3D_READER_HAS_GEOMETRY_READER)
+    message(FATAL_ERROR "Please provide either a VTK_IMPORTER or a VTK_READER")
+  endif ()
+
   string(JSON F3D_PLUGIN_JSON
     SET "${F3D_PLUGIN_JSON}" "readers" ${F3D_PLUGIN_CURRENT_READER_INDEX} "${F3D_READER_JSON}")
 

library/src/scene_impl.cxx

@@ -255,9 +255,8 @@ scene& scene_impl::add(const std::vector<fs::path>& filePaths)
     vtkSmartPointer<vtkImporter> importer = reader->createSceneReader(filePath.string());
     if (!importer)
     {
+      // XXX: F3D Plugin CMake logic ensure there is either a scene reader or a geometry reader
       auto vtkReader = reader->createGeometryReader(filePath.string());
-      // XXX: We assume the f3d reader provide either a scene reader or a geometry reader
-      // TODO: Put in f3d::reader directly
       assert(vtkReader);
       vtkSmartPointer<vtkF3DGenericImporter> genericImporter =
         vtkSmartPointer<vtkF3DGenericImporter>::New();