Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid short function on same line #1179

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

Meakk
Copy link
Member

@Meakk Meakk commented Jan 17, 2024

No description provided.

@Meakk Meakk requested a review from mwestphal January 17, 2024 14:48
@Meakk Meakk self-assigned this Jan 17, 2024
Copy link

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (b909482) 96.34% compared to head (fe27eb9) 96.32%.

Files Patch % Lines
library/VTKExtensions/Readers/vtkF3DEXRReader.h 0.00% 4 Missing ⚠️
...ry/VTKExtensions/Rendering/vtkF3DInteractorStyle.h 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1179      +/-   ##
==========================================
- Coverage   96.34%   96.32%   -0.03%     
==========================================
  Files         129      129              
  Lines        7861     7887      +26     
==========================================
+ Hits         7574     7597      +23     
- Misses        287      290       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Meakk Meakk force-pushed the clang-format-pass branch from 421100b to fe27eb9 Compare January 17, 2024 14:58
@Meakk Meakk merged commit 303ba1b into f3d-app:master Jan 17, 2024
45 of 46 checks passed
@Meakk Meakk deleted the clang-format-pass branch January 17, 2024 16:00
@mwestphal mwestphal mentioned this pull request Jan 23, 2024
mwestphal pushed a commit that referenced this pull request Feb 10, 2024
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants