Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quake MDL feature #1591
base: master
Are you sure you want to change the base?
Quake MDL feature #1591
Changes from all commits
dd41598
22e8941
55309ab
34c719a
b01355e
3180bd6
ec7995a
32ae40b
3301f24
83e8e68
f5e38b7
aa19fd0
45b8dce
9012a55
985211f
a5d5cf3
4e61407
afc778e
9cc1cf9
17a22dd
3bca4a6
c67fa76
b4a5532
85ec4f2
19607a5
417e857
417aa5b
c7ec807
54ea9d3
dbf44ed
4d1813d
48a6e7e
778c0d4
ae15baf
4af2189
f049d80
c8ce50a
932e2ba
f4c1865
b203e95
ac074e8
cff7f92
8a4744c
e9e9b06
ee4b66c
84b57f9
2f40a6f
36a374a
dda2a6a
bb76163
1eaca5b
3855830
3b6d59a
60c64d9
f26d21a
32bff66
e935a12
07cbe8c
825a55a
1e3f44a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to add DefaultConfig and ThumbnailConfig tests (see other tests named like this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what did you modify ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modified it with a hex editor for coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok but to reach which part of the importer code ? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it expected that the animation has an empty name ?