Add support for config defined bindings #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwestphal
force-pushed
the
interaction_config_files
branch
2 times, most recently
from
6d8d79c to
c2e5cd5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1740 +/- ##
==========================================
+ Coverage 95.70% 95.72% +0.01%
==========================================
Files 118 118
Lines 9392 9468 +76
==========================================
+ Hits 8989 9063 +74
- Misses 403 405 +2 ☔ View full report in Codecov by Sentry. |
|
You are modifying libf3d public API! |
mwestphal
commented
Nov 29, 2024
mwestphal
changed the title
mwestphal
changed the title
snoyer
reviewed
Dec 1, 2024
Meakk
reviewed
Dec 2, 2024
Meakk
reviewed
Dec 3, 2024
Works renaming Add tests fixups fixup tests fixup better testing coverage Revert "renaming" This reverts commit 2324230. Support order and multi commands Fixups fixups clfi fixups again doc space codespell fixups coverage last fixusp codespell review clfi Headeronly Revert "Headeronly" This reverts commit c25a76a.
mwestphal
force-pushed
the
interaction_config_files
branch
from
c25a76a to
8bf087e
Compare
Meakk
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Later:
Add user defined documentation support: #1747
Add glob support in config files: #1746
Add command-script option: #1734
Reenable test with command script:#1749
Improve command doc: #1749
Change minimal screenshot bind: #1715