Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scene: Improve behavior when failing to load a file #1883

Merged
merged 3 commits into from
Jan 5, 2025

Conversation

mwestphal
Copy link
Contributor

@mwestphal mwestphal commented Jan 5, 2025

Copy link

github-actions bot commented Jan 5, 2025

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

@mwestphal mwestphal requested a review from Meakk January 5, 2025 11:24
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.67%. Comparing base (f7c4796) to head (b5792d4).
Report is 464 commits behind head on release.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #1883      +/-   ##
===========================================
- Coverage    96.41%   95.67%   -0.75%     
===========================================
  Files          131      125       -6     
  Lines         8042     9937    +1895     
===========================================
+ Hits          7754     9507    +1753     
- Misses         288      430     +142     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal mwestphal mentioned this pull request Jan 5, 2025
34 tasks
@mwestphal mwestphal force-pushed the improve_failure_multifile branch from 36a9550 to bd9e356 Compare January 5, 2025 12:37
@mwestphal mwestphal force-pushed the improve_failure_multifile branch from bd9e356 to 975afc5 Compare January 5, 2025 12:51
@mwestphal mwestphal merged commit 0cfd5b9 into f3d-app:release Jan 5, 2025
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants