Collector: improve logging of graceful stream shutdown #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristinapathak
approved these changes
Mar 20, 2023
|
I still need to fix the exporter side, receiver-side races are I think fixed in my latest commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually test and improve the logs of an Arrow bridge configured with short-lived streams.
These logs no longer print spurious and duplicate information, since both streams handle two directions of error handling.
Errors are printed at Debug level if they are normal conditions. With this change, the bridge can shutdown streams gracefully with no unusual logging activity.
Part of #119.