Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Univariate metrics based on sparse union #30

Merged
merged 29 commits into from
Nov 10, 2022
Merged

Univariate metrics based on sparse union #30

merged 29 commits into from
Nov 10, 2022

Conversation

lquerel
Copy link
Contributor

@lquerel lquerel commented Nov 4, 2022 •
edited
Loading

This PR implements the encoding and decoding of univariate metrics based on Arrow union.

Gauge, Sum, and Summary encoding and decoding are implemented and tested.

Things that will be implemented in next PR:

@lquerel lquerel requested a review from jmacd November 4, 2022 22:43
lquerel and others added 20 commits November 4, 2022 15:43
@lquerel
Merge branch 'main' into Metrics-based-on-sparse-union
2ca1a02
@lquerel
Implement/Test quantile value builder
3a6d71f
@lquerel
Implement/Test summary data point and summary metrics
e298846
@lquerel
Implement/Test univariate metrics with 3 variants (i.e. gauge, sum, a…
253fa7a 
…nd summary).
@lquerel
Implement/Test metrics, resource metrics, and scope metrics.
020cf0b 
Move temporarily to Arrow v11 to fix an issue with Union and Struct (waiting for a v10.0.1).
@lquerel
[WIP] Metrics OTLP Arrow encoder
3da4bbf
@lquerel
Implement/Test metric value builder
9efaeee
@lquerel
Implement/Test metric exemplar and univariate number data point builder
d776d72
@lquerel
Implement/Test univariate gauge builder
7cbae5a
@lquerel
Implement/Test univariate sum builder
b180243
@lquerel
Implement/Test quantile value builder
0195f4c
@lquerel
Implement/Test summary data point and summary metrics
1485fe0
@lquerel
Implement/Test univariate metrics with 3 variants (i.e. gauge, sum, a…
e4e37aa 
…nd summary).
@lquerel
Implement/Test metrics, resource metrics, and scope metrics.
1429c2b 
Move temporarily to Arrow v11 to fix an issue with Union and Struct (waiting for a v10.0.1).
@lquerel
Merge with main
4cf642b
@lquerel
Merge remote-tracking branch 'origin/Metrics-based-on-sparse-union' i…
e2e4a03 
…nto Metrics-based-on-sparse-union

# Conflicts:
#	go.mod
@lquerel
[WIP] OTLP Arrow metrics decoder
13c7214
@lquerel
OTLP Arrow univariate metrics decoder
5b2e07f
@lquerel
Fix unit tests
d81ff96
@lquerel
Merge remote-tracking branch 'origin/main' into Metrics-based-on-spar…
9130043 
…se-union
@lquerel lquerel marked this pull request as ready for review November 9, 2022 19:41
@lquerel lquerel changed the title Metrics based on sparse union Univariate metrics based on sparse union Nov 9, 2022
@lquerel lquerel mentioned this pull request Nov 9, 2022
Closed
jmacd
jmacd reviewed Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Note: I've only just begun this review & have to stop for the day.)

pkg/otel/metrics/arrow/all_test.go Show resolved Hide resolved
jmacd
jmacd approved these changes Nov 10, 2022
View reviewed changes
pkg/datagen/metrics.go Show resolved Hide resolved
pkg/otel/common/arrow/attributes.go Outdated Show resolved Hide resolved
pkg/otel/common/arrow/attributes.go Outdated Show resolved Hide resolved
pkg/otel/metrics/arrow/metric_set.go Show resolved Hide resolved
pkg/otel/metrics/otlp/metrics.go Show resolved Hide resolved
@lquerel lquerel merged commit d19196b into main Nov 10, 2022
@jmacd jmacd deleted the Metrics-based-on-sparse-union branch April 7, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmacd jmacd jmacd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lquerel @jmacd