Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workflow] Delete size limit report #7128

Merged
merged 2 commits into from
Feb 4, 2025
Merged

[workflow] Delete size limit report #7128

merged 2 commits into from
Feb 4, 2025

Conversation

potatowagon
Copy link
Contributor

@potatowagon potatowagon commented Feb 4, 2025

deleting .github/workflows/size-limit.yml to cleanup S487385 . it is only the reporter for size limit results, and has been broken for awhile

I kept the size limit package around since im guessing the size limit cli tool could help debug size regressions? - lmk if this makes sense or should i uninstall size limit completely

Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:49am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:49am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 4, 2025
etrepum
etrepum previously approved these changes Feb 4, 2025
Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably be better to eliminate it altogether. It doesn't really get looked at, it didn't even work for most of the time it was there (not being able to comment on anything from forks, only measuring dev bundles, and/or measuring main vs. main), and nobody has paid much attention to what it is actually measuring. When/if someone at Meta wants to invest in this project they can invest the effort to do it correctly, probably with a different tool that can be used in a secure fashion. The reason it was done this way was half to work around how the size-limit action works, and the other half was because people outside of Meta don't really have credentials to implement the secure portion of it (commenting based on the results of the measurement)

@potatowagon potatowagon added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 7ea2d0d Feb 4, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants