drgn: refactor, cull dead code, and disable inline

facebookexperimental · May 4, 2023 · 96c80cb · 96c80cb
1 parent f70d349
commit 96c80cb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/extern/drgn b/extern/drgn
diff --git a/oi/SymbolService.cpp b/oi/SymbolService.cpp
@@ -500,6 +500,7 @@ static void parseFormalParam(Dwarf_Die& param,
   VLOG(1) << "Adding function arg address: " << farg;
 }
 
+/*
 static bool handleInlinedFunction(const irequest& request,
                                   std::shared_ptr<FuncDesc> funcDesc,
                                   struct drgn_qualified_type& funcType,
@@ -577,6 +578,7 @@ static bool handleInlinedFunction(const irequest& request,
   module = inlinedInstance->_private.module;
   return true;
 }
+*/
 
 static std::optional<std::shared_ptr<FuncDesc>> createFuncDesc(
     struct drgn_program* prog, const irequest& request) {
@@ -603,9 +605,11 @@ static std::optional<std::shared_ptr<FuncDesc>> createFuncDesc(
   }
 
   if (dwarf_func_inline(&funcDie) == 1) {
-    if (!handleInlinedFunction(request, fd, *ft, funcDie, module)) {
-      return std::nullopt;
-    }
+    // if (!handleInlinedFunction(request, fd, *ft, funcDie, module)) {
+    //   return std::nullopt;
+    // }
+    LOG(ERROR) << "inlined functions are not supported";
+    return std::nullopt;
   }
 
   ptrdiff_t offset = 0;
+0 −12		_drgn.pyi
+0 −4		drgn/__init__.py
+0 −1		libdrgn/Makefile.am
+7 −117		libdrgn/drgn.h.in
+80 −759		libdrgn/dwarf_info.c
+0 −53		libdrgn/dwarf_info.h
+1 −133		libdrgn/program.c
+0 −1		libdrgn/program.h
+0 −19		libdrgn/python/drgnpy.h
+0 −136		libdrgn/python/inlined.c
+0 −3		libdrgn/python/main.c
+0 −23		libdrgn/python/program.c
+0 −2		libdrgn/python/type.c
+0 −72		tests/test_inlined.py