-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspace Cargo.toml support + overhaul examples #54
base: main
Are you sure you want to change the base?
Workspace Cargo.toml support + overhaul examples #54
Conversation
Also fixes CI, hopefully. |
d6173a4
to
ea56b0e
Compare
This is impossible in BUCK files. They are the owners of their filesystem tree and nothing else.
Pass through and buckify their dependencies, but skip the member crates themselves. This is important for buckifying a workspace Cargo.toml.
This allows us do configuration keys like `manifest_path = "..."` / `third_party_dir = "..."` in reindeer.toml.
dbd1636
to
e73d588
Compare
…m config Creates third party dir if it doesn't exist.
e113201
to
43fb4bb
Compare
b93d715
to
36e657f
Compare
35bd38b
to
1296df5
Compare
Ok, everything works except windows, and I don't have a windows machine to dig any further into that at the moment. I'm using the exact same
Even though
|
1296df5
to
84194e5
Compare
84194e5
to
198f4f5
Compare
Edit, figured out what that was and documented it in the reindeer.toml. Mismatch between prelude's platform names and the ones in this file. |
Fixes #51 by
vendor
with third-party/...manifest_path = "..."
+third_party_dir = "..."
to reindeer.toml, allowing it to live at your workspace root and just point to where the output should go.include_workspace_members = false
(default false) because you often want to write your own BUCK files for those instead of having them mixed into a huge generated BUCK file.Altogether you get
reindeer --manifest-path ./Cargo.toml --third-party-dir subdirectory buckify
, and because this is not something I expect people will want to type, the new config parameters get that down to justreindeer buckify
. The layout is as as below.Includes a cargo fmt, let me know if this is wrong, maybe there is configuration drift between this repo & others at meta.