-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--[WIP][BE/Refactor/Bugfix] Remove deprecated distutils from setup and ab_test #2202
Draft
jturner65
wants to merge
2
commits into
main
Choose a base branch
from
RemoveDistutilsFromSetup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+38
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcd3bc
to
562580c
Compare
94b0634
to
7399bf4
Compare
7c7bdb4
to
246500f
Compare
e7c3f98
to
153c984
Compare
153c984
to
d0490ac
Compare
36750ac
to
a73637b
Compare
1d3155f
to
3139d0c
Compare
3139d0c
to
56298a4
Compare
Skylion007
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably also bump the supported versions for our conda builds.
Latest version of pybind11 supports python 3.12. Also latest versions of torch will too now. |
a21bc23
to
f4075ad
Compare
f6767f7
to
46c8648
Compare
46c8648
to
a7727fc
Compare
708372c
to
693af4b
Compare
336955f
to
f39421a
Compare
f33e56e
to
73fae5e
Compare
6723fa4
to
4d8fed8
Compare
4d8fed8
to
d18eecb
Compare
d18eecb
to
46f1c11
Compare
b6a472d
to
36f2b91
Compare
36f2b91
to
9843784
Compare
ae91b20
to
d279d43
Compare
9ffa254
to
f2c33c8
Compare
f2c33c8
to
97835a0
Compare
13231ea
to
759dafe
Compare
759dafe
to
25307bb
Compare
05ace7d
to
4efaca2
Compare
4efaca2
to
3c05254
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Distutils is deprecated and will be removed in python 3.12, which is slated for release Oct 2 2023. This PR removes references to Distutils in HabitatSim python code. It does require the 'packaging' library, so this also needs to be added to requirements.txt. (@Skylion007 is there a better option than this to provide version classes?)
NOTE : Our versions of bullet, assimp and pybind11 all also have distutils references, so we may need to update these libraries before we can claim python 3.12 support. (magnum also does, but I'm sure mosra will address when appropriate).
How Has This Been Tested
Types of changes
Checklist