Fix segfault in gfx-replay when there's an invalid path. #2537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
aclegg3
approved these changes
Jan 24, 2025
| pair.second); | ||
| const auto& it = createdInstances_.find(instanceKey); | ||
| if (it == createdInstances_.end()) { | ||
| // Missing instance for this key due to a failed instance creation |
There was a problem hiding this comment.
Should this log an error message or something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This fixes a segfault that can occur in gfx-replay when an asset has an invalid path.
How Has This Been Tested
Tested locally on HITL.
Types of changes
Checklist