Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[not4land] Finalizer based registration #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,16 @@ add_library(
src/cpp/flashlight_binding.cc
)

# Flashlight <> JS finalizer bindings
add_library(flashlight_finalizer_binding SHARED src/cpp/finalizer.cc)
target_include_directories(flashlight_finalizer_binding PRIVATE src/cpp/napi/)
target_link_libraries(
flashlight_finalizer_binding
PRIVATE
flashlight::flashlight
)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -undefined dynamic_lookup")

# Write lib to the project root
set_target_properties(
flashlight_binding
Expand Down
1 change: 1 addition & 0 deletions examples/test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@ for (let i = 0; i < 10000; ++i) {
m += a.add(b).mean().toFloat32()
}
const t1 = performance.now() / 1e3
Bun.gc(true)
console.log(t1 - t0, 'seconds to calculate', m)
2 changes: 1 addition & 1 deletion examples/train.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ const optimize = (...args) => {
}
}

const show_timing = false
const show_timing = true
const traint0 = performance.now()
let floss = 0
for (let i = 0; i < 1000; ++i) {
Expand Down
37 changes: 37 additions & 0 deletions src/cpp/finalizer.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
#include <iostream>
#include <node_api.h>

#include "flashlight/fl/tensor/tensor.h"

#define DOUBLE_ENCODE_OFFSET_BIT 49
#define DOUBLE_ENCODE_OFFSET (1ll << DOUBLE_ENCODE_OFFSET_BIT)

extern "C" {

void deleter(napi_env env, void *t, void * /*ignore*/) {
auto *tensor = reinterpret_cast<fl::Tensor *>(t);
delete tensor;
}

napi_value finalize(napi_env env, napi_callback_info info) {
napi_value this_arg;
napi_value argv[2];
size_t argc = 2;
auto status = napi_get_cb_info(env, info, &argc, argv, &this_arg, NULL);
// grab the 2nd argument directly
int64_t ptr_int = ((int64_t *)info)[7];
void *ptr = (void *)(ptr_int - DOUBLE_ENCODE_OFFSET);
auto *tensor = reinterpret_cast<fl::Tensor *>(ptr);
int64_t adjusted;
napi_adjust_external_memory(env, tensor->bytes(), &adjusted);
napi_add_finalizer(env, argv[0], ptr, deleter, NULL, NULL);
return (napi_value)0xaaaaaa;
}

napi_value napi_register_module_v1(napi_env env, napi_value exports) {
napi_property_descriptor desc = {"finalize", 0, finalize, 0,
0, 0, napi_default, 0};
auto status = napi_define_properties(env, exports, 1, &desc);
return exports;
}
}
458 changes: 458 additions & 0 deletions src/cpp/napi/js_native_api.h

Large diffs are not rendered by default.

156 changes: 156 additions & 0 deletions src/cpp/napi/js_native_api_types.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,156 @@
#ifndef SRC_JS_NATIVE_API_TYPES_H_
#define SRC_JS_NATIVE_API_TYPES_H_

// This file needs to be compatible with C compilers.
// This is a public include file, and these includes have essentially
// became part of it's API.
#include <stddef.h> // NOLINT(modernize-deprecated-headers)
#include <stdint.h> // NOLINT(modernize-deprecated-headers)

#if !defined __cplusplus || (defined(_MSC_VER) && _MSC_VER < 1900)
typedef uint16_t char16_t;
#endif

// JSVM API types are all opaque pointers for ABI stability
// typedef undefined structs instead of void* for compile time type safety
typedef struct napi_env__ *napi_env;
typedef struct napi_value__ *napi_value;
typedef struct napi_ref__ *napi_ref;
typedef struct napi_handle_scope__ *napi_handle_scope;
typedef struct napi_escapable_handle_scope__ *napi_escapable_handle_scope;
typedef struct napi_callback_info__ *napi_callback_info;
typedef struct napi_deferred__ *napi_deferred;

typedef enum {
napi_default = 0,
napi_writable = 1 << 0,
napi_enumerable = 1 << 1,
napi_configurable = 1 << 2,

// Used with napi_define_class to distinguish static properties
// from instance properties. Ignored by napi_define_properties.
napi_static = 1 << 10,

#if NAPI_VERSION >= 8
// Default for class methods.
napi_default_method = napi_writable | napi_configurable,

// Default for object properties, like in JS obj[prop].
napi_default_jsproperty = napi_writable | napi_enumerable | napi_configurable,
#endif // NAPI_VERSION >= 8
} napi_property_attributes;

typedef enum {
// ES6 types (corresponds to typeof)
napi_undefined,
napi_null,
napi_boolean,
napi_number,
napi_string,
napi_symbol,
napi_object,
napi_function,
napi_external,
napi_bigint,
} napi_valuetype;

typedef enum {
napi_int8_array,
napi_uint8_array,
napi_uint8_clamped_array,
napi_int16_array,
napi_uint16_array,
napi_int32_array,
napi_uint32_array,
napi_float32_array,
napi_float64_array,
napi_bigint64_array,
napi_biguint64_array,
} napi_typedarray_type;

typedef enum {
napi_ok,
napi_invalid_arg,
napi_object_expected,
napi_string_expected,
napi_name_expected,
napi_function_expected,
napi_number_expected,
napi_boolean_expected,
napi_array_expected,
napi_generic_failure,
napi_pending_exception,
napi_cancelled,
napi_escape_called_twice,
napi_handle_scope_mismatch,
napi_callback_scope_mismatch,
napi_queue_full,
napi_closing,
napi_bigint_expected,
napi_date_expected,
napi_arraybuffer_expected,
napi_detachable_arraybuffer_expected,
napi_would_deadlock // unused
} napi_status;
// Note: when adding a new enum value to `napi_status`, please also update
// * `const int last_status` in the definition of `napi_get_last_error_info()'
// in file js_native_api_v8.cc.
// * `const char* error_messages[]` in file js_native_api_v8.cc with a brief
// message explaining the error.
// * the definition of `napi_status` in doc/api/n-api.md to reflect the newly
// added value(s).

typedef napi_value (*napi_callback)(napi_env env, napi_callback_info info);
typedef void (*napi_finalize)(napi_env env, void *finalize_data,
void *finalize_hint);

typedef struct {
// One of utf8name or name should be NULL.
const char *utf8name;
napi_value name;

napi_callback method;
napi_callback getter;
napi_callback setter;
napi_value value;

napi_property_attributes attributes;
void *data;
} napi_property_descriptor;

typedef struct {
const char *error_message;
void *engine_reserved;
uint32_t engine_error_code;
napi_status error_code;
} napi_extended_error_info;

#if NAPI_VERSION >= 6
typedef enum {
napi_key_include_prototypes,
napi_key_own_only
} napi_key_collection_mode;

typedef enum {
napi_key_all_properties = 0,
napi_key_writable = 1,
napi_key_enumerable = 1 << 1,
napi_key_configurable = 1 << 2,
napi_key_skip_strings = 1 << 3,
napi_key_skip_symbols = 1 << 4
} napi_key_filter;

typedef enum {
napi_key_keep_numbers,
napi_key_numbers_to_strings
} napi_key_conversion;
#endif // NAPI_VERSION >= 6

#if NAPI_VERSION >= 8
typedef struct {
uint64_t lower;
uint64_t upper;
} napi_type_tag;
#endif // NAPI_VERSION >= 8

#endif // SRC_JS_NATIVE_API_TYPES_H_
Loading