-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement StandardScaler
; add associated tests
#132
base: main
Are you sure you want to change the base?
Conversation
Also, noticed that Bun's GC is eager to the point that when running consecutive Accordingly, I've updated the test to check that the memory is less than or equal to memory usage at the start of the test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just a couple suggestions
Biggest issue is the weirdness w test CI runs failing due to mismatched Tweaked implementation to debug a few errors I was catching locally. |
Going to implement remaining class methods so that it's at feature parity with the |
At this point, I think there's either something I'm missing in the implementation causing failure on Linux runs due to Welcome feedback with regard to the implementation; I have largely directly ported this Golang sklearn port as I'm more familiar with Go than python. |
Currently, it's failing on GPU when comparing |
Implemented
BaseScaler
abstract class +StandardScaler
, which extends the base class. Also added simple unit tests forStandardScaler
.Fixed a few type errors in
shumai/tensor/tensor.ts
while working on this.