refactor: Proxy and cache avatar images #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gauthier-th
requested changes
Aug 1, 2024
gauthier-th
reviewed
Aug 5, 2024
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
JoaquinOlivero
force-pushed
the
cache-avatar
branch
from
bb5b51d to
7e7a65c
Compare
github-actions
bot
removed
the
merge conflict
gauthier-th
previously approved these changes
Aug 16, 2024
|
No problem at all work's great ! |
Gauvino
reviewed
Aug 17, 2024
JoaquinOlivero
force-pushed
the
cache-avatar
branch
from
374eaee to
808e616
Compare
gauthier-th
previously approved these changes
Aug 20, 2024
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
|
@JoaquinOlivero could you resolve the conflicts? So we can get this in EDIT: its okay I have done it c: |
github-actions
bot
removed
the
merge conflict
JoaquinOlivero
force-pushed
the
cache-avatar
branch
from
722bf2b to
b46d247
Compare
JoaquinOlivero
force-pushed
the
cache-avatar
branch
from
b46d247 to
1306a2a
Compare
gauthier-th
requested changes
Aug 27, 2024
JoaquinOlivero
force-pushed
the
cache-avatar
branch
from
d461189 to
e6e2523
Compare
gauthier-th
requested changes
Sep 4, 2024
fallenbagel
approved these changes
Sep 11, 2024
3 tasks
fallenbagel
approved these changes
Sep 16, 2024
fallenbagel
requested changes
Sep 16, 2024
Gauvino
reviewed
Sep 16, 2024
added 16 commits
September 18, 2024 02:43
…plicates for different users
JoaquinOlivero
force-pushed
the
cache-avatar
branch
from
17e852e to
c195a6f
Compare
gauthier-th
approved these changes
Sep 18, 2024
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
bonswouar
pushed a commit
to bonswouar/jellyseerr
that referenced
this pull request
Nov 10, 2024
* refactor: proxy and cache user avatar images * fix: extract keys * fix: set avatar image URL * fix: show the correct avatar in the list of available users in advanced request * fix(s): set correct src URL for cached image * fix: remove unexpired unused image when a user changes their avatar * fix: requested changes * refactor: use 'mime' package to detmerine file extension * style: grammar * refactor: checks if the default avatar is cached to avoid creating duplicates for different users * fix: fix vulnerability * fix: fix incomplete URL substring sanitization * refactor: only cache avatar with http url protocol * fix: remove log and correctly set the if statement for the cached image component * fix: avatar images not showing on issues page * style: formatting --------- Co-authored-by: JoaquinOlivero <[email protected]>
thibodelanghe
pushed a commit
to thibodelanghe/jellyseerr
that referenced
this pull request
Dec 18, 2024
* refactor: proxy and cache user avatar images * fix: extract keys * fix: set avatar image URL * fix: show the correct avatar in the list of available users in advanced request * fix(s): set correct src URL for cached image * fix: remove unexpired unused image when a user changes their avatar * fix: requested changes * refactor: use 'mime' package to detmerine file extension * style: grammar * refactor: checks if the default avatar is cached to avoid creating duplicates for different users * fix: fix vulnerability * fix: fix incomplete URL substring sanitization * refactor: only cache avatar with http url protocol * fix: remove log and correctly set the if statement for the cached image component * fix: avatar images not showing on issues page * style: formatting --------- Co-authored-by: JoaquinOlivero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes how Jellyseerr handles profile images. Now they are proxied from the source and cached in the disk.
The caching mechanism uses the already existing "ImageProxy" class which I tweaked.
Also, I added a new endpoint "/avatarproxy" that takes the URL from the images, caches them if needed, and then returns them.
Screenshot (if UI-related)
To-Dos
pnpm buildpnpm i18n:extractIssues Fixed or Closed