-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
farmOS 3.1.0 + Inventory quick form blog posts #25
Conversation
✅ Deploy Preview for farmos-community-blog-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good the me. 👍
posts/2024/farmOS-3.1.0/index.md
Outdated
asset inventory levels. Just select the asset you want to adjust and enter the | ||
quantity (as a "reset", "increment", or "decrement")! There are some more | ||
advanced options too, which are described in a dedicated post: | ||
[Inventory Quick Form](inventory-quick-form) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link doesn't work, on deploy preview it points to /blog/inventory-quick-form
but the post is at /blog/2024/inventory-quick-form
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrm I can't seem to get this to work right. :-(
I tried changing it to /blog/2024/inventory-quick-form
but that resulted in a link to /blog/blog/2024/inventory-quick-form
.
I also tried ./inventory-quick-form
(in case the ./
was helpful) but that had the same effect as the original issue (link to /blog/inventory-quick-form
.
So it seems we may have a bug in the farmOS.org codebase's link generator, but only for blog posts? 🤔
Bummer. Well for the sake of this PR, I suppose we should just decide how it should work in blog posts. I think relative linking makes sense, right? So then we just need to figure out why it isn't being generated correctly in farmOS.org's code.
Alternatively, I could change it to an absolute link to https://farmOS.org/blog/2024/inventory-quick-form
, but that means the preview wouldn't work, and it feels like it could cause future issues if we ever move things around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also just noticed (relatedly) that the second link in this 3.0.0 post is broken in the same way on the live site: https://farmos.org/blog/2024/farmOS-3.0.0/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using post slugs instead of folder names in relative links seems to generate working links:
wotnak@e689094
https://deploy-preview-6--wotnak-farmos-blog-preview.netlify.app/blog/2024/farmOS-3.1.0/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good find @wotnak! Thanks! I included your commit in the PR. I'll make note of that in farmOS/farmOS.org#90 too.
7c5ffdc
to
fd6aee2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Draft blog post announcing the release of farmOS 3.1.0 with summary of highlights, and a dedicated blog post for the new Inventory quick form.
The Inventory quick form post is largely copied and modified from the Movement quick form post: https://farmos.org/blog/2023/movement-quick-form/
Open to feedback/suggestions/word-smithing on the 3.1.0 post! I didn't give it a lot of time. The hope is that we can send this out as a first farmOS community newsletter, too, so we may want to add more to it with that in mind.