Fix serialization when pagination is empty (#491)

* bug fix * update codes
fastapi-practices · Jan 18, 2025 · cf693cd · cf693cd
1 parent 3fe0023
commit cf693cd
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/backend/common/pagination.py b/backend/common/pagination.py
@@ -54,27 +54,27 @@ class _CustomPage(_PageDetails, AbstractPage[T], Generic[T]):
     @classmethod
     def create(
         cls,
-        items: Sequence[SchemaT],
+        items: list,
         total: int,
         params: _CustomPageParams,
     ) -> _CustomPage[T]:
         page = params.page
         size = params.size
         total_pages = ceil(total / params.size)
-        links = create_links(**{
-            'first': {'page': 1, 'size': f'{size}'},
-            'last': {'page': f'{ceil(total / params.size)}', 'size': f'{size}'} if total > 0 else 1,
-            'next': {'page': f'{page + 1}', 'size': f'{size}'} if (page + 1) <= total_pages else None,
-            'prev': {'page': f'{page - 1}', 'size': f'{size}'} if (page - 1) >= 1 else None,
-        }).model_dump()
+        links = create_links(
+            first={'page': 1, 'size': size},
+            last={'page': f'{ceil(total / params.size)}', 'size': size} if total > 0 else {'page': 1, 'size': size},
+            next={'page': f'{page + 1}', 'size': size} if (page + 1) <= total_pages else None,
+            prev={'page': f'{page - 1}', 'size': size} if (page - 1) >= 1 else None,
+        ).model_dump()
 
         return cls(
             items=items,
             total=total,
             page=params.page,
             size=params.size,
             total_pages=total_pages,
-            links=links,
+            links=links,  # type: ignore
         )