feat: add email to users #64
Conversation
|
You can proceed to update the auth too if you feel motivated. |
EnzoDOROSARIO
force-pushed
the
feat/user-emails
branch
2 times, most recently
from
b1bfded to
45a9e6b
Compare
|
EnzoDOROSARIO
force-pushed
the
feat/user-emails
branch
from
6b857e4 to
fbefdfd
Compare
| @@ -4,7 +4,7 @@ import { build } from '../../../helper.js' | |||
| import { FastifyInstance } from 'fastify' | |||
| import { scryptHash } from '../../../../src/plugins/custom/scrypt.js' | |||
|
|
|||
| async function createUser (app: FastifyInstance, userData: Partial<{ username: string; password: string }>) { | |||
| async function createUser (app: FastifyInstance, userData: Partial<{ username: string; email: string; password: string }>) { | |||
There was a problem hiding this comment.
Same, email can be created dynamically.
| const res = await this.inject({ | ||
| method: 'POST', | ||
| url: '/api/auth/login', | ||
| payload: { | ||
| username, | ||
| email, |
There was a problem hiding this comment.
You can automate the creation of the email from the username by doing '${username}@example.com'.
There was a problem hiding this comment.
I did that first, but if the authentication should be based on email, wouldn't it be better if the tests reflected this?
|
If you pull the last changes, sonarcloud should not fail anymore. |
|
|
Thanks @EnzoDOROSARIO! |
Description
Prepare #49
Checklist
npm run testandnpm run benchmarkand the Code of conduct