Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_haml? is no longer available. Use ActionView::Base instead #1185

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

steveyken
Copy link
Member

Recent versions of haml gem no longer have the is_haml? method so taking a different approach to indentifying callback context.

@steveyken steveyken requested a review from CloCkWeRX October 26, 2023 04:44
@CloCkWeRX
Copy link
Member

CloCkWeRX commented Oct 26, 2023

Ah, this is a good one to sort out. I hadn't quite understood why knowing if something was haml or not was important so have kept knocking back the haml 6 gem updates.
ie:
#1010

@CloCkWeRX CloCkWeRX merged commit 0acdc65 into master Oct 26, 2023
8 checks passed
@CloCkWeRX CloCkWeRX deleted the fix-callback-hook branch October 26, 2023 12:19
@steveyken
Copy link
Member Author

Great! Thanks for merging. Yes, is_haml? never really felt like the right thing to be doing. Should be backwards compatible as far as I tell but I haven't tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants