Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule emails to deliver asynchronously #1188

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Schedule emails to deliver asynchronously #1188

merged 1 commit into from
Oct 28, 2023

Conversation

steveyken
Copy link
Member

Using deliver_later rather than deliver_now will send emails in a separate async thread (default in development).

This enables better integration with Rails ActiveJob configurations which may be altered to use a more robust queuing solution (e.g. delayed_job / sidekiq) in production setups.

It also removes email generation/sending from the main request thread and hence speeds up response times.

@steveyken steveyken requested a review from CloCkWeRX October 28, 2023 03:12
@CloCkWeRX CloCkWeRX merged commit 92bebce into master Oct 28, 2023
8 checks passed
@steveyken steveyken deleted the deliver_later branch August 21, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants