Schedule emails to deliver asynchronously #1188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
deliver_later
rather thandeliver_now
will send emails in a separate async thread (default in development).This enables better integration with Rails ActiveJob configurations which may be altered to use a more robust queuing solution (e.g. delayed_job / sidekiq) in production setups.
It also removes email generation/sending from the main request thread and hence speeds up response times.