Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple custom field groups on new entity creation #1325

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

stanleylhs
Copy link
Member

@stanleylhs stanleylhs commented Aug 20, 2024

This code fixes introduces new code to handle multiple field groups in the following scenario:

  • Create a tag called 'Tag1'
  • Create two Contact field groups that are both tagged with Tag1.
  • Create at least one custom field in each field group
  • Create a new contact and add 'Tag1'

Expected outcome:

  • Both field groups are ajax-loaded into the form

Actual outcome:

  • Only one of the field groups is ajax-loaded

@stanleylhs stanleylhs requested a review from steveyken August 20, 2024 10:31
Copy link
Member

@steveyken steveyken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This makes sense to cover off this edge case. I have also added some ordering to the query to ensure a consistent UI experience.

@steveyken steveyken merged commit a2c0372 into master Aug 21, 2024
8 checks passed
@steveyken steveyken deleted the fix-multiple-custom-field-groups-create branch August 21, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants