Fix solution dimensions #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahlanzrath
requested changes
Dec 4, 2024
This is now handled by CADET-Python
schmoelder
force-pushed
the
fix_solution_dimensions
branch
from
9d35ce5 to
2b16f9b
Compare
hannahlanzrath
requested changes
Dec 4, 2024
CADET-Core now returns a 1D Vector (instead of a 2D where the second dimension happens to only have one entry).
schmoelder
force-pushed
the
fix_solution_dimensions
branch
from
2b16f9b to
e42c05e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts CADET-Process to improve handling the solution of CADET simulations.
Note, this requires
To do: