Remove --json flag on commands that do not support it #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptpaterson
approved these changes
Jan 27, 2025
cleve-fauna
approved these changes
Jan 29, 2025
cleve-fauna
force-pushed
the
580-json-has-no-effect-for-several-commands
branch
from
4cf66ae to
5fd3c7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
--jsonis a global formatting option, but not all commands support it or even have an output.Solution
Move
--jsonout of the global option space and into each individual command that supports it.Result
--jsonwill only show up in the commands that actually support it. Passing--jsonto a command that doesn't support it will not cause an error.Testing
All commands supporting JSON have a test proving it.