Fixed Full Name mentions, $ as trigger, and incorrect matches, combined merge requests #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
accept pull
Merging changes to fix multiple bugs
|
Also merged in @darshanpp's fix! |
revroad-dev
changed the title
Merge pull request #1 from darshanpp/master
|
Merged in @rajc4c since I took my fix from his pull request originally |
revroad-dev
changed the title
|
@fayeed feel free to contact me with any questions. Would love to see this merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 2 bugs. One where you could not use the $ as a trigger because it was a special character, and 1 where It would match substrings
. This should not match 'Hello' as this is a new tag.