Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enh]: Improving the error messages for module_linker #99

Closed
wants to merge 1 commit into from

Conversation

nakul-py
Copy link

@nakul-py nakul-py commented Dec 4, 2024

@Y-Nak
Copy link
Collaborator

Y-Nak commented Dec 4, 2024

Thank you for your contribution to the project!

However, upon reviewing this pull request, it seems that the changes proposed are unrelated to the scope of the original issue. The issue specifically refers to enhancing error messages generated by the ModuleLinker component. The modifications in this PR appear to focus on test-related error formatting, which is not directly connected to the ModuleLinker.

If you’d like to contribute to the original issue, please consider reviewing the ModuleLinker implementation. If you have any questions, feel free to ask me!

@nakul-py
Copy link
Author

nakul-py commented Dec 5, 2024

Will i contribute to this branch Y-Nak:ir-module-linking

@Y-Nak
Copy link
Collaborator

Y-Nak commented Dec 5, 2024

Yes, it's the correct branch. Please refer to crates/codegen/src/module_linker.rs. Curretly, it's not possible to specify the module name, so please start from 2. Describe the Inconsistency, or just add the name: String field to Module and tweak ModuleBuider. Thank you.

@nakul-py
Copy link
Author

nakul-py commented Dec 5, 2024

I can't able to work in https://github.com/Y-Nak/sonatina/tree/ir-module-linking as i have forked the main repository https://github.com/fe-lang/sonatina. Will you merge your module-linking pr #96 to the main repo.

@Y-Nak
Copy link
Collaborator

Y-Nak commented Dec 6, 2024

#96 is merged. I moved the module_linker.rs to crates/ir/src/module_linker.rs. Please refer to it.

@nakul-py nakul-py marked this pull request as draft December 8, 2024 14:16
@Y-Nak
Copy link
Collaborator

Y-Nak commented Dec 8, 2024

Close this PR in favor of #102

@Y-Nak Y-Nak closed this Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Error Messages in ModuleLinker
2 participants