Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISCOVERY-348: Add Community section (basely init) #354

Merged
merged 13 commits into from
Nov 9, 2021

Conversation

azinit
Copy link
Member

@azinit azinit commented Nov 8, 2021

DISCLAIMER

Вы ведь уже догадались, да?)

image

image

CHANGELOG

  • feat: Добавил раздел "Комьюнити" c awesome-ресурсами
fs.community.-.awesome.mp4

UPD

А, ну и да, для понимания "А зачем вообще отдельный комьюнити раздел? Что там будет?"

Чисто комьюнити ресурсы, в отрыве от методологии, как это сделано у:

А вот, то что планируется добавить в ближ время

image

Чеклист

  • Если при работе с документацией потребовалось использовать github-дискуссии, то стоит их прикрепить как see-also источники
  • Если PR связан с задачей, то необходимо проверить, что все требования по задаче выполнены
  • Перед тем, как отправлять изменения на ревью, нужно ознакомиться с CONTIBUTING-гайдлайнами
  • Перед тем, как отправлять изменения на ревью, нужно провести self-review своих изменений
  • Перед тем, как отправлять изменения на ревью, нужно дождаться CI-проверок
  • Перед тем, как отправлять изменения на ревью, нужно дать краткое описание изменений

@azinit azinit linked an issue Nov 8, 2021 that may be closed by this pull request
15 tasks
Copy link
Member Author

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-reviewed

Comment on lines +60 to +64
{
label: "💫 Community",
to: SECTIONS.COMMUNITY.shortPath,
activeBasePath: SECTIONS.COMMUNITY.shortPath,
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавляем в навбар

Comment on lines +1 to +18
---
sidebar_position: 1
---

# Awesome Resources

[![Awesome](https://awesome.re/badge.svg)](https://awesome.re)

A curated list of awesome feature-sliced videos, articles, packages

Found something cool? Please, **[contribute](https://github.com/feature-sliced/awesome/pulls)**!

## Community

- [FeatureSliced Telegram (RU)](https://t.me/feature_sliced)
- [FeatureSliced Twitter](https://twitter.com/feature_sliced)
- [FeatureSliced YouTube](https://www.youtube.com/channel/UCkng_PHLatpDKPOIKfI731A)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Позже сделаю так, чтобы автоматом обновлялось при апдейтах в репозитории

#353

Comment on lines +1 to +40
---
sidebar_position: 0
sidebar_class_name: sidebar-item--root
hide_table_of_contents: true
slug: /community
pagination_prev: about/index
---

# 💫 Community

<span class="badge badge--info margin-bottom--md">COMMUNITY-ORIENTED</span>

<p class="summary">
Community resources, additional materials
</p>

## Main

import Row from "@site/src/shared/ui/row/tmpl.mdx"
import { StarOutlined, SearchOutlined, TeamOutlined } from "@ant-design/icons";

<Row
title="Awesome Resources"
description="A curated list of awesome feature-sliced videos, articles, packages"
to="/docs/community/awesome"
Icon={StarOutlined}
/>
<Row
title="Team"
description="Core-team, Champions, Contributors, Companies"
to="/docs/community/team"
Icon={TeamOutlined}
/>
<Row
title="Contributing"
description="HowTo, Workflow, Support"
to="#"
Icon={SearchOutlined}
disabled
/>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Обычная овервью страничка с указанием основных статей

Comment on lines +12 to +18

### Champions

## Contributors

## Companies
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Перенес к комьюнити, наметил базово структуру

Так скоро и статью добью)

#349

Comment on lines +126 to +133
tags={['Mission','Promote & Integration']}
/>
<Row
title="Community"
description="Community resources, additional materials"
to="/docs/community"
Icon={"💫"}
tags={['Awesome','Team', 'Contributing']}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Отсылаемся на раздел комьюнити из интро

Comment on lines +35 to +39
title="Contributing"
description="HowTo, Workflow, Support"
to="#"
Icon={SearchOutlined}
disabled
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дизейблед, т.к. пока еще не сделана страничка

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Также "ругается", если передаешь урл, которого нет в роутах

Поэтому пока решетка пусть будет

image

Comment on lines +5 to +15
# Awesome Resources

[![Awesome](https://awesome.re/badge.svg)](https://awesome.re)

Подборка интересных видео, статей и тулкита

Нашли что-то классное? Пожалуйста, **[поделитесь](https://github.com/feature-sliced/awesome/pulls)**!

## Комьюнити

- [FeatureSliced Telegram (RU)](https://t.me/feature_sliced)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ну и тож самое для русской версии 1-1

Comment on lines +38 to +41
"item.label.💫 Community": {
"message": "💫 Сообщество",
"description": "Navbar item with label Community"
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Локализация навбара

Comment on lines +21 to +24
communitySidebar: [
{ type: "autogenerated", dirName: "community" },
{ type: "link", href: "/examples", label: "Examples" },
],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это для сайдбара конфиг + чтобы examples были доступны отдельной ссылкой, как у докузауруса
https://docusaurus.io/community/team

image

Comment on lines +23 to +27
<Link
className={clsx(styles.root, className, disabled && styles.rootDisabled)}
to={to}
onClick={handleClick}
>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Собсна yet-one-upgrade наших NavRow

Copy link

@spotsccc spotsccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Выглядит очень круто! оставил пару незначительных комментов по локализации, но возможно их вообще исправлять не нужно:)

@@ -35,6 +35,10 @@
"message": "🍰 О методологии",
"description": "Navbar item with label About"
},
"item.label.💫 Community": {
"message": "💫 Сообщество",
"description": "Navbar item with label Community"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А где эти дескрипшины отображаются, их точно не надо локализовывать?(я в доказаурусе не силен)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Они чисто для перевода нужны, да)

Чисто по спеке i18n, чтобы переводить словари было проще для разных локалей

https://docusaurus.io/docs/2.0.0-beta.8/i18n/introduction#json-files
image

@azinit
Copy link
Member Author

azinit commented Nov 9, 2021

@feature-sliced/core @feature-sliced/contributors review pls

@azinit azinit merged commit a97fe4a into master Nov 9, 2021
@azinit azinit deleted the features/DISCOVERY-348-community--awesome branch November 9, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DISCOVERY: (Community) Fullfill Awesome page
3 participants