refactor: change order of layer descriptions #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the image and the description of the layers are arranged in different sequences, this can lead to difficulties for beginners when getting acquainted with the FSD architecture.
👷 Deploy request for pr-fsd pending review.Visit the deploys page to approve it
|
|
Hi, thanks for the PR! I do see the logic in keeping the same order as the image, perhaps it is indeed better that way. Could you also change the English version please? |
Since the image and the description of the layers are arranged in different sequences, this can lead to difficulties for beginners when getting acquainted with the FSD architecture.
|
That's it, I've done it. I fixed this for the en-version as well. |
illright
approved these changes
May 4, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Since the image and the description of the layers are arranged in different sequences, this can lead to difficulties for beginners when getting acquainted with the FSD architecture.
Changelog