Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added usage with nuxt guide #679

Merged
merged 8 commits into from
Jun 16, 2024
Merged

feat: added usage with nuxt guide #679

merged 8 commits into from
Jun 16, 2024

Conversation

falkomerr
Copy link
Contributor

@falkomerr falkomerr commented Jun 10, 2024

Added "Usage with NuxtJS" article with English and Russian translations

Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for pr-fsd ready!

Name Link
🔨 Latest commit 40fb5e4
🔍 Latest deploy log https://app.netlify.com/sites/pr-fsd/deploys/666ed33f0031170009cba956
😎 Deploy Preview https://deploy-preview-679--pr-fsd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@illright
Copy link
Member

Really happy to see this, thanks! I'll take some time soon to read it and review properly

Copy link
Member

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: overall, great guide, nice and concise

Maybe you can also endorse some templates that exist for Nuxt projects (if you agree with their structure)? We have two currently in our awesome repo: https://github.com/feature-sliced/awesome

@falkomerr
Copy link
Contributor Author

https://github.com/SbokyZahodi/FSD-Nuxt3-template/tree/main
https://github.com/yunglocokid/FSD-Pure-Nuxt3-Template

The templates look good in my opinion, but they don't have the src/ folder in them

@falkomerr falkomerr requested a review from illright June 15, 2024 09:28
@illright
Copy link
Member

Yep, all good with the previous comments. Just a couple of minor formatting fixes:

  • make the page title in English the same as other pages in that category (Usage with NuxtJS instead of Use with NuxtJS)
  • the code blocks with folder structure are a bit misaligned in some places, could you go through them and fix the alignment please?
  • the English version is missing a filename in the code block of app/routes/home/index.vue
  • in the Russian version, the fsd command has some whitespace in the beginning

@illright illright merged commit 2c291ac into feature-sliced:master Jun 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants