Merge pull request #109 from rokashkovvd/master

fix: add app layer rule
feature-sliced · Apr 30, 2024 · fa3ad76 · fa3ad76
2 parents 03091f4 + b883dfe
commit fa3ad76
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 5 deletions.
diff --git a/rules/layers-slices/index.js b/rules/layers-slices/index.js
@@ -6,10 +6,16 @@ const getNotSharedLayersRules = () =>
         allow: layersLib.getLowerLayers(layer),
     }));
 
-const sharedLayerRule = {
-    from: "shared",
-    allow: "shared",
-};
+const slicelessLayerRules = [
+    {
+        from: "shared",
+        allow: "shared",
+    },
+    {
+        from: "app",
+        allow: "app",
+    }
+];
 
 const getLayersBoundariesElements = () =>
     layersLib.FS_LAYERS.map((layer) => ({
@@ -46,7 +52,7 @@ module.exports = {
             {
                 "default": "disallow",
                 "message": "\"${file.type}\" is not allowed to import \"${dependency.type}\" | See rules: https://feature-sliced.design/docs/reference/layers/overview ",
-                "rules": [...getNotSharedLayersRules(), sharedLayerRule, ...getGodModeRules()],
+                "rules": [...getNotSharedLayersRules(), ...slicelessLayerRules, ...getGodModeRules()],
             },
         ],
     },

diff --git a/rules/layers-slices/layers.test.js b/rules/layers-slices/layers.test.js
@@ -102,4 +102,26 @@ describe("Import boundaries between layers", () => {
         assert.strictEqual(report[0].errorCount, 0);
     });
 
+    it("should lint without errors when import from app.", async () => {
+        const validCodeSnippet = [
+            `import "app/styles/styles.css"`,
+            `import { withProviders } from "app/providers"`,
+        ].join("\n");
+
+        const report = await eslint.lintText(validCodeSnippet, {
+            filePath: "src/app/ui/app.tsx",
+        });
+        assert.strictEqual(report[0].errorCount, 0);
+    });
+
+    it("should lint with errors when import from app.", async () => {
+        const wrongImports = [
+            `import { withProviders } from "app/providers"`,
+        ];
+
+        const report = await eslint.lintText(wrongImports.join("\n"), {
+            filePath: "src/features/add-user/model.tsx",
+        });
+        assert.strictEqual(report[0].errorCount, wrongImports.length);
+    });
 });