Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINT-55(HOTFIX): Incorrect import order working with aliases. #64

Merged
merged 2 commits into from
Jan 8, 2022

Conversation

Krakazybik
Copy link
Member

@Krakazybik Krakazybik commented Dec 31, 2021

Description

Добавлено:

  • Поддержка корневых альясов для import-order
  • Тесты на корневые альясы для import-order

Example:

        import { Cart } from "@/entities/cart";
        import { Input } from "~/shared/ui";

References

#55 #58
#55 (comment)

Checklist

  • Description added
  • Self-reviewed
  • CI pass

@Krakazybik Krakazybik self-assigned this Dec 31, 2021
@Krakazybik Krakazybik added the bug Something isn't working label Dec 31, 2021
@Krakazybik Krakazybik requested a review from azinit December 31, 2021 15:34
Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥

Comment on lines 33 to 39
import { Header } from "widgets/header"; // 2.1) Layers: widgets
import { LoginForm } from "features/login-form"; // 2.2) Layers: features
import { authModel } from "entities/auth"; // 2.3) Layers: entities
import { Cart } from "@/entities/cart"; // Layers: entities - Alias
import { Input } from "~/shared/ui"; // Layers: shared - Alias
import { Button } from "shared/ui"; // 2.4) Layers: shared
import { debounce } from "shared/lib/fp"; // 2.4) Layers: shared
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Топчик проверка!

@azinit azinit merged commit c581251 into master Jan 8, 2022
@azinit azinit deleted the hotfix/LINT-55-incorrect-alias-import-order branch January 8, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants