Skip update if old package can't be installed #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://pagure.io/fedora-ci/general/issue/382 https://gitlab.com/testing-farm/oculus/-/issues/18 Ideally, the prepare phase of downgrade test would do the same, i.e. first remove package, then try to install the old one and if that fails, skip the test, otherwise update to the new package. But that'd be 3 operations (remove, install, update) more than what we do now for every package just for a very rare use-case (old package can't be installed). Now the prep-downgrade does nothing because the previous (update) test leaves the new package installed.
This way we can distinguish such tests in the viewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pagure.io/fedora-ci/general/issue/382
https://gitlab.com/testing-farm/oculus/-/issues/18
Ideally, the prepare phase of the downgrade test would do the same, i.e.
first remove package, then try to install the old one and if that fails, skip the test, otherwise update to the new package.
But that'd be 3 operations (remove, install, update) more than what we do now for every package just for a very rare use-case (old package can't be installed).
Now the prep-downgrade does nothing because the previous (update) test leaves the new package installed.
Also, have separate exit code for skipped tests so that we can distinguish them in the viewer.